hamradio: fix issue of dev reference count leakage in bpq_device_event()
authorZhengchao Shao <shaozhengchao@huawei.com>
Thu, 3 Nov 2022 09:09:05 +0000 (17:09 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Nov 2022 09:32:28 +0000 (09:32 +0000)
commit85cbaf032d3cd9f595152625eda5d4ecb1d6d78d
tree327e59580f50536870b6135cc20639e80e2cf792
parent531705a765493655472c993627106e19f7e5a6d2
hamradio: fix issue of dev reference count leakage in bpq_device_event()

When following tests are performed, it will cause dev reference counting
leakage.
a)ip link add bond2 type bond mode balance-rr
b)ip link set bond2 up
c)ifenslave -f bond2 rose1
d)ip link del bond2

When new bond device is created, the default type of the bond device is
ether. And the bond device is up, bpq_device_event() receives the message
and creates a new bpq device. In this case, the reference count value of
dev is hold once. But after "ifenslave -f bond2 rose1" command is
executed, the type of the bond device is changed to rose. When the bond
device is unregistered, bpq_device_event() will not put the dev reference
count.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hamradio/bpqether.c