sctp: drop __packed from almost all SCTP structures
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Tue, 7 Feb 2017 13:37:56 +0000 (11:37 -0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Feb 2017 19:11:04 +0000 (14:11 -0500)
commit85c727b5948344c8d559e2fda8925e9ddd41c29a
treeca4a55955cedd8871f53b00e859b3d51b9489ace
parentbb580ad698aeb4e5455d701c228c50355f84c056
sctp: drop __packed from almost all SCTP structures

__packed is considered harmful as it potentially generates code that
doesn't perform well and its usage should be avoided as much as
possible.

This patch drops __packed from all SCTP structures except one, which is
sctp_signed_cookie. In there it's required, as per changelog on
commit 9834a2bb4970 ("[SCTP]: Fix sctp_cookie alignment in the packet.").

After this patch, no alignment changes neither in x86 or x86_64 and
no exceptions were noticed during testing on both archs.

Code size for SCTP module also didn't change with this patch.

Cc: David Miller <davem@davemloft.net>
Cc: David Laight <David.Laight@ACULAB.COM>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/sctp.h
include/net/sctp/structs.h