tg3: avoid double-freeing of rx data memory
authorIvan Vecera <ivecera@redhat.com>
Wed, 6 Nov 2013 13:02:36 +0000 (14:02 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Nov 2013 00:09:44 +0000 (19:09 -0500)
commit85aec73d595b8847f9c4ea571deb127913f0d508
treee4d2fcdd4cb1d6e1dd93f835cfc708e7476a4ed0
parent28fb96552472d8ef6197f6dc4c768cf8a64c570d
tg3: avoid double-freeing of rx data memory

If build_skb fails the memory associated with the ring buffer is freed but
the ri->data member is not zeroed in this case. This causes a double-free
of this memory in tg3_free_rings->... path. The patch moves this block after
setting ri->data to NULL.
It would be nice to fix this bug also in stable >= v3.4 trees.

Cc: Nithin Nayak Sujir <nsujir@broadcom.com>
Cc: Michael Chan <mchan@broadcom.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c