[spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init
authorYao Qi <yao.qi@linaro.org>
Wed, 8 Apr 2015 15:04:07 +0000 (16:04 +0100)
committerYao Qi <yao.qi@linaro.org>
Wed, 8 Apr 2015 15:04:07 +0000 (16:04 +0100)
commit85558555ec343f6e8ec32da409c838954e68132f
tree7d6ded92befafb237ece864765833c7b1a2780f7
parent151411f8af16723a12e0e0eedc1ecdbea648c1b0
[spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init

Nowadays, in infrun.c:resume, the setting to 'step' variable is like:

  if (use_displaced_stepping (gdbarch)
      && tp->control.trap_expected
      && sig == GDB_SIGNAL_0
      && !current_inferior ()->waiting_for_vfork_done)
    {
    }
  /* Do we need to do it the hard way, w/temp breakpoints?  */
  else if (step)
    step = maybe_software_singlestep (gdbarch, pc); <-- [1]

  ...

  if (execution_direction != EXEC_REVERSE
      && step && breakpoint_inserted_here_p (aspace, pc))
    {
      ...
      if (gdbarch_cannot_step_breakpoint (gdbarch)) <-- [2]
        step = 0;
    }

spu doesn't have displaced stepping and uses software single step,
so 'step' is set to zero in [1], and [2] becomes unreachable as a
result.  So don't have to call set_gdbarch_cannot_step_breakpoint
in spu_gdbarch_init.

gdb:

2015-04-08  Yao Qi  <yao.qi@linaro.org>

* spu-tdep.c (spu_gdbarch_init): Don't call
set_gdbarch_cannot_step_breakpoint.
gdb/ChangeLog
gdb/spu-tdep.c