Make sure rid specific libs projs get packaged (#57193)
authorViktor Hofer <viktor.hofer@microsoft.com>
Wed, 11 Aug 2021 10:50:46 +0000 (12:50 +0200)
committerGitHub <noreply@github.com>
Wed, 11 Aug 2021 10:50:46 +0000 (12:50 +0200)
commit85441ce69b81dfd5bf57b9d00ba525440b7bb25d
treecc61690fc004f48c81af08b204da05ff192e28f5
parentc0662e8129beaf93b8050d39a863cc6d16a0308c
Make sure rid specific libs projs get packaged (#57193)

* Make sure rid specific libs projs get packaged

RID specific runtime.*.runtime.native.System.IO.Ports projects weren't
packaged because the GeneratePackageOnBuild property wasn't set to true
for them. The property was only true during an allconfigurations build.
As these projects are only built outside of an allconfigurations build,
the GeneratePackageOnBuild property needs to account for such as well.

Also updating the NoTargets Sdk to clean the rid specific package up.

Moving the GeneratePackageOnBuild logic into a props file and set it to
false during servicing (or runtimelab) so that devs can set the property
during servicing directly in the project file if a project should be
packaged.

* Remove the GeneratePackage property

That property was intended to enabled incremental servicing but with
now using the NuGet Pack task we can just make use of the publicl
available GeneratePackageOnBuild property.

* Fix IsPackable setting
Directory.Build.props
Directory.Build.targets
eng/packaging.props [deleted file]
eng/packaging.targets
global.json
src/libraries/Directory.Build.props
src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props