f2fs: call f2fs_balance_fs outside of locked page
authorJaegeuk Kim <jaegeuk@kernel.org>
Tue, 3 Dec 2019 23:53:16 +0000 (15:53 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:36:23 +0000 (08:36 +0100)
commit85275286d118c863167d5ad86342221e3433ca4f
tree877b1f7742585dd1050fb386f971d4cc43c1b327
parent678b25bfd983c6d4d24adc243022428cbca63531
f2fs: call f2fs_balance_fs outside of locked page

[ Upstream commit bdf03299248916640a835a05d32841bb3d31912d ]

Otherwise, we can hit deadlock by waiting for the locked page in
move_data_block in GC.

 Thread A                     Thread B
 - do_page_mkwrite
  - f2fs_vm_page_mkwrite
   - lock_page
                              - f2fs_balance_fs
                                  - mutex_lock(gc_mutex)
                               - f2fs_gc
                                - do_garbage_collect
                                 - ra_data_block
                                  - grab_cache_page
   - f2fs_balance_fs
    - mutex_lock(gc_mutex)

Fixes: 39a8695824510 ("f2fs: refactor ->page_mkwrite() flow")
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/f2fs/file.c