media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe()
authorTuo Li <islituo@gmail.com>
Thu, 5 Aug 2021 07:55:35 +0000 (09:55 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 30 Sep 2021 08:07:54 +0000 (10:07 +0200)
commit8515965e5e33f4feb56134348c95953f3eadfb26
tree9312eb2fb588f0d5ea5cb3801049bb436e758fcd
parentea8a5c118e2491726ffd27fd3fc149110d104095
media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe()

The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is
checked in:
  if (!dev->plat_dev)

This indicates both dev->plat_dev and pdev can be NULL. If so, the
function dev_err() is called to print error information.
  dev_err(&pdev->dev, "No platform data specified\n");

However, &pdev->dev is an illegal address, and it is dereferenced in
dev_err().

To fix this possible null-pointer dereference, replace dev_err() with
mfc_err().

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Tuo Li <islituo@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/s5p-mfc/s5p_mfc.c