scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND
authorJan Kara <jack@suse.cz>
Thu, 23 Oct 2014 02:13:39 +0000 (20:13 -0600)
committerJens Axboe <axboe@fb.com>
Thu, 23 Oct 2014 02:13:39 +0000 (20:13 -0600)
commit84ce0f0e94ac97217398b3b69c21c7a62ebeed05
treeedcef07ab6269ba6fb5ae02206de428b2a8f96f6
parent31f9690e6eaf549f3e643f6a8f7dab84fd31997a
scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND

When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where we just end up copying
(luckily zeroed-out) kernel buffer to userspace instead of reporting
error. Fix the problem by jumping to the right label.

CC: Jens Axboe <axboe@kernel.dk>
CC: linux-scsi@vger.kernel.org
CC: stable@vger.kernel.org
Coverity-id: 1226871
Signed-off-by: Jan Kara <jack@suse.cz>
Fixed up the, now unused, out label.

Signed-off-by: Jens Axboe <axboe@fb.com>
block/scsi_ioctl.c