misc: tifm: fix possible memory leak in tifm_7xx1_switch_media()
authorruanjinjie <ruanjinjie@huawei.com>
Thu, 17 Nov 2022 06:47:25 +0000 (14:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:29 +0000 (13:14 +0100)
commit848c45964ded537107e010aaf353aa30a0855387
tree339e3dba0173a3c9c822f76b8f5ca24eef783c0e
parent37a13b274e4513c757e50c002ddcbf4bc89adbb2
misc: tifm: fix possible memory leak in tifm_7xx1_switch_media()

[ Upstream commit fd2c930cf6a5b9176382c15f9acb1996e76e25ad ]

If device_register() returns error in tifm_7xx1_switch_media(),
name of kobject which is allocated in dev_set_name() called in device_add()
is leaked.

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Fixes: 2428a8fe2261 ("tifm: move common device management tasks from tifm_7xx1 to tifm_core")
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20221117064725.3478402-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/tifm_7xx1.c