cgroup: cgroup_get_from_id() must check the looked-up kn is a directory
authorMing Lei <ming.lei@redhat.com>
Fri, 23 Sep 2022 11:51:19 +0000 (19:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Oct 2022 08:39:36 +0000 (10:39 +0200)
commit8484a356cee8ce3d6a8e6266ff99be326e9273ad
tree54b0f030d17d32ecfab9b9ad8dfa6dd8a2487729
parentae04dd5ef1801784eb0717de2141e094d7544195
cgroup: cgroup_get_from_id() must check the looked-up kn is a directory

[ Upstream commit df02452f3df069a59bc9e69c84435bf115cb6e37 ]

cgroup has to be one kernfs dir, otherwise kernel panic is caused,
especially cgroup id is provide from userspace.

Reported-by: Marco Patalano <mpatalan@redhat.com>
Fixes: 6b658c4863c1 ("scsi: cgroup: Add cgroup_get_from_id()")
Cc: Muneendra <muneendra.kumar@broadcom.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: stable@vger.kernel.org # v5.14+
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/cgroup/cgroup.c