USB: EHCI: Improve port index sanitizing
authorAlan Stern <stern@rowland.harvard.edu>
Sat, 2 Oct 2021 19:02:17 +0000 (15:02 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Oct 2021 10:52:03 +0000 (12:52 +0200)
commit846cbf98cbef20376b1a95fa3734c435543f3519
tree1bd9a61c7a2a2d57121f906b7e763272175a826f
parentef53d3db1c59fe7893baf4dca851d3d3daff04b6
USB: EHCI: Improve port index sanitizing

Now that Kees Cook has added a definition for HCS_N_PORTS_MAX in
commit 72dd1843232c ("USB: EHCI: Add register array bounds to HCS
ports"), the code in ehci_hub_control() which sanitizes port index
values can be improved a little.

The idea behind this change is that it prevents a possible
out-of-bounds pointer computation, which the compiler might be able to
detect since the port_status[] array now has a fixed length rather
than a variable length.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20211002190217.GA537967@rowland.harvard.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-hub.c