[Sema] Fix PR22637 - IndirectFieldDecl's discard qualifiers during template instantia...
authorEric Fiselier <eric@efcs.ca>
Sun, 8 Apr 2018 05:11:59 +0000 (05:11 +0000)
committerEric Fiselier <eric@efcs.ca>
Sun, 8 Apr 2018 05:11:59 +0000 (05:11 +0000)
commit84393619eb09be1516b52b09efb6ac30ee63d625
treeabcf01f84edb1d762e6a281cdf175fc3fcb99895
parent0eb86c8efc0a3a21b4bdcad64c58d4a3e2fa7c35
[Sema] Fix PR22637 - IndirectFieldDecl's discard qualifiers during template instantiation.

Summary:
Currently Clang fails to propagate qualifiers from the `CXXThisExpr` to the rebuilt `FieldDecl` for IndirectFieldDecls. For example:

```
template <class T> struct Foo {
  struct { int x; };
  int y;
  void foo() const {
      static_assert(__is_same(int const&, decltype((y))));
      static_assert(__is_same(int const&, decltype((x)))); // assertion fails
  }
};
template struct Foo<int>;
```

The fix is to delegate rebuilding of the MemberExpr to `BuildFieldReferenceExpr` which correctly propagates the qualifiers.

Reviewers: rsmith, lebedev.ri, aaron.ballman, bkramer, rjmccall

Reviewed By: rjmccall

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D45412

llvm-svn: 329517
clang/lib/Sema/TreeTransform.h
clang/test/SemaCXX/PR22637.cpp [new file with mode: 0644]
clang/test/SemaCXX/cxx0x-nontrivial-union.cpp