pinctrl: starfive: jh7110: Fix failure to set irq after CONFIG_PM is enabled
authorHal Feng <hal.feng@starfivetech.com>
Tue, 5 Sep 2023 12:21:04 +0000 (20:21 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 12 Sep 2023 08:09:40 +0000 (10:09 +0200)
commit8406d6b5916663b4edc604b3effbf4935b61c2da
tree147d9f0d70f35e0dd70e44146d839a0f29ee09a7
parent87d315a34133edcb29c4cadbf196ec6c30dfd47b
pinctrl: starfive: jh7110: Fix failure to set irq after CONFIG_PM is enabled

The issue was found when we enabled CONFIG_PM and tested edge events using
libgpiod.

> # gpiomon -r gpiochip0 55
> gpiomon: error waiting for events: Permission denied

`gpiomon` will call irq_chip_pm_get() and then call pm_runtime_resume_and_get()
if (IS_ENABLED(CONFIG_PM) && sfp->gc.irq.domain->pm_dev).
pm_runtime_resume_and_get() will fail if the runtime pm of pinctrl device
is disabled.

As we expect the pinctrl driver can be always working and never suspend
during runtime, unset sfp->gc.irq.domain->pm_dev to make sure
pm_runtime_resume_and_get() won't be called when setting irq.

Fixes: 447976ab62c5 ("pinctrl: starfive: Add StarFive JH7110 sys controller driver")
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
Link: https://lore.kernel.org/r/20230905122105.117000-2-hal.feng@starfivetech.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c