pinctrl: thunderbay: fix possible memory leak in thunderbay_build_functions()
authorGaosheng Cui <cuigaosheng1@huawei.com>
Tue, 29 Nov 2022 12:01:26 +0000 (20:01 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 6 Dec 2022 14:28:14 +0000 (15:28 +0100)
commit83e1bcaf8cef26edaaf2a6098ef760f563683483
tree4c19aaa54523d3dc969921a49b86dedc884fc9dd
parent80b99ed74e234e82298531c459c29343d0a8bcf2
pinctrl: thunderbay: fix possible memory leak in thunderbay_build_functions()

The thunderbay_add_functions() will free memory of thunderbay_funcs
when everything is ok, but thunderbay_funcs will not be freed when
thunderbay_add_functions() fails, then there will be a memory leak,
so we need to add kfree() when thunderbay_add_functions() fails to
fix it.

In addition, doing some cleaner works, moving kfree(funcs) from
thunderbay_add_functions() to thunderbay_build_functions().

Fixes: 12422af8194d ("pinctrl: Add Intel Thunder Bay pinctrl driver")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Reviewed-by: Rafał Miłecki <rafal@milecki.pl>
Link: https://lore.kernel.org/r/20221129120126.1567338-1-cuigaosheng1@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-thunderbay.c