[lld/mac] Tweak estimateStubsInRangeVA a bit
authorNico Weber <thakis@chromium.org>
Sat, 28 Aug 2021 03:27:03 +0000 (23:27 -0400)
committerNico Weber <thakis@chromium.org>
Mon, 30 Aug 2021 17:56:45 +0000 (13:56 -0400)
commit83df94067d367d91dcc37e269a3d7317ebe97bb4
tree862e7f856de1602224c7712aa90cad25e74554ef
parent0529e2e01888129b21becd1fe3a61d9cb07c6fcd
[lld/mac] Tweak estimateStubsInRangeVA a bit

- Move a few variables closer to their uses, remove some completely
  (no behavior change)
- Add some comments
- Make maxPotentialThunks include calls to stubs. It's possible that
  an earlier call to a stub late in the stub table will need a thunk,
  and that inserted thunk could push a stub earlier in the stub table
  out of range. This is unlikely to happen, but usually there are
  way fewer stub calls than non-stub calls, so if we're doing a
  conservative approximation here we might as well do it correctly.
  (For chromium's unit_tests target, 134421/242639 stub calls are
  direct calls without this change, compared to 134408/242639 with
  this change)

No real, meaningful behavior difference.

Differential Revision: https://reviews.llvm.org/D108924
lld/MachO/ConcatOutputSection.cpp