drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap
authorRob Herring <robh@kernel.org>
Thu, 24 Oct 2019 19:18:59 +0000 (14:18 -0500)
committerRob Herring <robh@kernel.org>
Tue, 29 Oct 2019 18:29:21 +0000 (13:29 -0500)
commit83b8a6f242ea6b4eafe69afcd0bfa428235f2ee4
treee9ffbb31af9d5d19de02d4dc509f3b8be7e39499
parent9e62b885f71568d166c97b040b4b2e218c2a5584
drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap

Commit c40069cb7bd6 ("drm: add mmap() to drm_gem_object_funcs")
introduced a GEM object mmap() hook which is expected to subtract the
fake offset from vm_pgoff. However, for mmap() on dmabufs, there is not
a fake offset.

To fix this, let's always call mmap() object callback with an offset of 0,
and leave it up to drm_gem_mmap_obj() to remove the fake offset.

TTM still needs the fake offset, so we have to add it back until that's
fixed.

Fixes: c40069cb7bd6 ("drm: add mmap() to drm_gem_object_funcs")
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20191024191859.31700-1-robh@kernel.org
drivers/gpu/drm/drm_gem.c
drivers/gpu/drm/drm_gem_shmem_helper.c
drivers/gpu/drm/ttm/ttm_bo_vm.c
include/drm/drm_gem.h