USB: serial: cp210x: fix CP2105 GPIO registration
authorJohan Hovold <johan@kernel.org>
Fri, 26 Nov 2021 09:43:48 +0000 (10:43 +0100)
committerJohan Hovold <johan@kernel.org>
Tue, 14 Dec 2021 08:22:05 +0000 (09:22 +0100)
commit83b67041f3eaf33f98a075249aa7f4c7617c2f85
tree5d836c3e6287e99c3ff1690d49ba6fb117ac0eb3
parent2585cf9dfaaddf00b069673f27bb3f8530e2039c
USB: serial: cp210x: fix CP2105 GPIO registration

When generalising GPIO support and adding support for CP2102N, the GPIO
registration for some CP2105 devices accidentally broke. Specifically,
when all the pins of a port are in "modem" mode, and thus unavailable
for GPIO use, the GPIO chip would now be registered without having
initialised the number of GPIO lines. This would in turn be rejected by
gpiolib and some errors messages would be printed (but importantly probe
would still succeed).

Fix this by initialising the number of GPIO lines before registering the
GPIO chip.

Note that as for the other device types, and as when all CP2105 pins are
muxed for LED function, the GPIO chip is registered also when no pins
are available for GPIO use.

Reported-by: Maarten Brock <m.brock@vanmierlo.com>
Link: https://lore.kernel.org/r/5eb560c81d2ea1a2b4602a92d9f48a89@vanmierlo.com
Fixes: c8acfe0aadbe ("USB: serial: cp210x: implement GPIO support for CP2102N")
Cc: stable@vger.kernel.org # 4.19
Cc: Karoly Pados <pados@pados.hu>
Link: https://lore.kernel.org/r/20211126094348.31698-1-johan@kernel.org
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tested-by: Maarten Brock <m.brock@vanmierlo.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/cp210x.c