avoid python exception in FrameDecorator.py
authorTom Tromey <tromey@redhat.com>
Wed, 22 Jan 2014 15:52:15 +0000 (08:52 -0700)
committerTom Tromey <tromey@redhat.com>
Thu, 23 Jan 2014 15:03:52 +0000 (08:03 -0700)
commit83b645b833a4c137441b2ba1c03206371b28c9db
tree7f973cdbe3487cbfed37f55d40d432136ce9d19c
parent0740f8d82dd18e48d1531c8d86b531341fc9e099
avoid python exception in FrameDecorator.py

This fixes a bug in FrameDecorator.py.

FrameVars seems to assume that Frame.block can return None if there is
no block.  However, it actually throws an exception.

I saw this bug while developing a frame filter, but unfortunately I
don't know how to reproduce it.  It seems to me that the SAL tests in
_is_limited_frame should exclude the bad cases; and in my attempts to
write a test they do.

Nevertheless I think the fix is reasonably obvious and ought to go in.

2014-01-23  Tom Tromey  <tromey@redhat.com>

PR python/16485:
* python/lib/gdb/FrameDecorator.py: (FrameVars.fetch_frame_args):
Handle exception from frame.block.
(FrameVars.fetch_frame_locals): Likewise.
gdb/ChangeLog
gdb/python/lib/gdb/FrameDecorator.py