[llvm-readelf] - Don't print OS/Processor specific prefix for known ELF file types.
authorGeorgii Rymar <grimar@accesssoftek.com>
Mon, 14 Dec 2020 15:04:45 +0000 (18:04 +0300)
committerGeorgii Rymar <grimar@accesssoftek.com>
Tue, 15 Dec 2020 07:56:25 +0000 (10:56 +0300)
commit83aea14ed6118c810e4ed2966bc34db9b42cb049
tree2206710969fdf754bfcfd73bbb5d43f74a470b97
parent8b330f1f6919a2ac85eeda753ad8d1090468e23f
[llvm-readelf] - Don't print OS/Processor specific prefix for known ELF file types.

This is a change suggested in post commit comments for
D93096 (https://reviews.llvm.org/D93096#2451796).

Imagine we want to add a custom OS specific ELF file type.
For that we can update the `ElfObjectFileType` array:

```
static const EnumEntry<unsigned> ElfObjectFileType[] = {
...
  {"Core",         "CORE (Core file)",         ELF::ET_CORE},
  {"MyType",       "MyType (my description)",     0xfe01},
};
```

The current code then might print:
```
OS Specific: (MyType (my description))
```

Though instead we probably would like to see a nicer output, e.g:
```
Type: MyType (my description)
```

To achieve that we can reorder the code slightly.

It is impossible to add a test I think, because we have no custom values in
the `ElfObjectFileType` array in LLVM.

Differential revision: https://reviews.llvm.org/D93217
llvm/tools/llvm-readobj/ELFDumper.cpp