KEYS: trusted: Fix memory leak on object td
authorColin Ian King <colin.king@canonical.com>
Fri, 30 Apr 2021 11:37:24 +0000 (12:37 +0100)
committerJarkko Sakkinen <jarkko@kernel.org>
Wed, 12 May 2021 19:36:36 +0000 (22:36 +0300)
commit83a775d5f9bfda95b1c295f95a3a041a40c7f321
tree659ffcc6d800f6949fcc400e7a718ff86fba05fb
parentdbb5afad100a828c97e012c6106566d99f041db6
KEYS: trusted: Fix memory leak on object td

Two error return paths are neglecting to free allocated object td,
causing a memory leak. Fix this by returning via the error return
path that securely kfree's td.

Fixes clang scan-build warning:
security/keys/trusted-keys/trusted_tpm1.c:496:10: warning: Potential
memory leak [unix.Malloc]

Cc: stable@vger.kernel.org
Fixes: 5df16caada3f ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
security/keys/trusted-keys/trusted_tpm1.c