x86-64: Restore PIC check for PCREL reloc against protected symbol
authorH.J. Lu <hjl.tools@gmail.com>
Wed, 6 Feb 2019 02:45:23 +0000 (18:45 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Wed, 6 Feb 2019 02:45:34 +0000 (18:45 -0800)
commit83924b3846361f2f76f9a6e7b5afa01c0eebbd4f
tree46f38366ea637c07bb5e61b3afdc8dc83f8458be
parent4e9ac437aaebb55624b54fc3d1cfb52acfe320dd
x86-64: Restore PIC check for PCREL reloc against protected symbol

commit bd7ab16b4537788ad53521c45469a1bdae84ad4a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Feb 13 07:34:22 2018 -0800

    x86-64: Generate branch with PLT32 relocation

removed check R_X86_64_PC32 relocation against protected symbols in
shared objects.  Since elf_x86_64_check_relocs is called after we
have seen all input files, we can check for PC-relative relocations in
elf_x86_64_check_relocs.  We should not allow PC-relative relocations
against protected symbols since address of protected function and
location of protected data may not be in the shared object.

bfd/

PR ld/24151
* elf64-x86-64.c (elf_x86_64_need_pic): Check
SYMBOL_DEFINED_NON_SHARED_P instead of def_regular.
(elf_x86_64_relocate_section): Move PIC check for PC-relative
relocations to ...
(elf_x86_64_check_relocs): Here.
(elf_x86_64_finish_dynamic_symbol): Use SYMBOL_DEFINED_NON_SHARED_P
to check if a symbol is defined in a non-shared object.
* elfxx-x86.h (SYMBOL_DEFINED_NON_SHARED_P): New.

ld/

PR ld/24151
* testsuite/ld-x86-64/pr24151a-x32.d: New file.
* testsuite/ld-x86-64/pr24151a.d: Likewise.
* testsuite/ld-x86-64/pr24151a.s: Likewise.
* testsuite/ld-x86-64/x86-64.exp: Run pr24151a and pr24151a-x32.
bfd/ChangeLog
bfd/elf64-x86-64.c
bfd/elfxx-x86.h
ld/ChangeLog
ld/testsuite/ld-x86-64/pr24151a-x32.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/pr24151a.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/pr24151a.s [new file with mode: 0644]
ld/testsuite/ld-x86-64/x86-64.exp