udc: net2280: Fix net2280_disable
authorGuido Kiener <guido.kiener@rohde-schwarz.com>
Mon, 4 Feb 2019 18:04:20 +0000 (19:04 +0100)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 6 Feb 2019 06:40:09 +0000 (08:40 +0200)
commit836bcab50624d728abeab3766f356d54c48ea1b1
treea9ace50ed187bc12fbd974e837bfb887594b9f55
parent1e19a520a9258f3c7286826e7172e56bf6da86dc
udc: net2280: Fix net2280_disable

A reset e.g. calling ep_reset_338x() can happen while endpoints
are enabled. The ep_reset_338x() sets ep->desc = NULL to mark
endpoint being invalid. A subsequent call of net2280_disable will
fail and return -EINVAL to parent function usb_ep_disable(),
which will fail, too, and do not set the member ep->enabled = false.

See:
https://elixir.bootlin.com/linux/v5.0-rc5/source/drivers/usb/gadget/udc/core.c#L139

This fix ignores dp->desc and allows net2280_disable() to succeed.
Subsequent calls to usb_ep_enable()/usb_ep_disable() succeeds.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/net2280.c