cifs: fix double-free of "string" in cifs_parse_mount_options
authorJeff Layton <jlayton@redhat.com>
Thu, 13 Dec 2012 11:02:51 +0000 (06:02 -0500)
committerSteve French <sfrench@us.ibm.com>
Thu, 20 Dec 2012 17:27:16 +0000 (11:27 -0600)
commit8367224b2e90eb716dc54f3d83cd73b7efb2ea30
treeec9990e14663cd4416e44c633f55d23a86f56717
parent1800098549fc310cffffefdcb3722adaad0edda8
cifs: fix double-free of "string" in cifs_parse_mount_options

Dan reported the following regression in commit d387a5c5:

    + fs/cifs/connect.c:1903 cifs_parse_mount_options() error: double free of 'string'

That patch has some of the new option parsing code free "string" without
setting the variable to NULL afterward. Since "string" is automatically
freed in an error condition, fix the code to just rely on that instead
of freeing it explicitly.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/connect.c