drm/sun4i: hdmi: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 22 May 2023 15:53:31 +0000 (15:53 +0000)
committerKees Cook <keescook@chromium.org>
Thu, 1 Jun 2023 14:07:37 +0000 (07:07 -0700)
commit8360257608f74946a985400f1994d3eea9b74a85
tree6cf619967150de59643034bcfec50d4fda99b30d
parent3213bfde114f9ce37e2a0264d368dcf8a2347bea
drm/sun4i: hdmi: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230522155331.2336966-1-azeemshaikh38@gmail.com
drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c