percpu: restructure pcpu_extend_area_map() to fix bugs and improve readability
authorTejun Heo <tj@kernel.org>
Wed, 11 Nov 2009 06:35:18 +0000 (15:35 +0900)
committerTejun Heo <tj@kernel.org>
Thu, 12 Nov 2009 15:55:35 +0000 (00:55 +0900)
commit833af8427be4b217b5bc522f61afdbd3f1d282c2
tree7af86f8c599c4513f81c9b37ec34926cb4728316
parent4a6cc4bd32e580722882115d4c8b964d732c11e4
percpu: restructure pcpu_extend_area_map() to fix bugs and improve readability

pcpu_extend_area_map() had the following two bugs.

* It should return 1 if pcpu_lock was dropped and reacquired but it
  returned 0.  This could lead to oops if free_percpu() races with
  area map extension.

* pcpu_mem_free() was called under pcpu_lock.  pcpu_mem_free() might
  end up calling vfree() which isn't IRQ safe.  This could lead to
  deadlock through lock order inversion via IRQ.

In addition, Linus pointed out that the temporary lock dropping and
subtle three-way return value of pcpu_extend_area_map() was very ugly
and suggested to split the function into two - pcpu_need_to_extend()
and pcpu_extend_area_map().

This patch restructures pcpu_extend_area_map() as suggested and fixes
the two bugs.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>
mm/percpu.c