net: dsa: sja1105: recalculate gating subschedule after deleting tc-gate rules
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 24 Jun 2020 13:54:46 +0000 (16:54 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Jun 2020 23:06:56 +0000 (16:06 -0700)
commit82f6896a25ee2471fdf039eb7b286a692d78f504
tree349167f30fbeb538d38ca2f9161aba0956b93eff
parent026bdb2b96525edd1fb5cc6f24587ff08d277d5c
net: dsa: sja1105: recalculate gating subschedule after deleting tc-gate rules

Currently, tas_data->enabled would remain true even after deleting all
tc-gate rules from the switch ports, which would cause the
sja1105_tas_state_machine to get unnecessarily scheduled.

Also, if there were any errors which would prevent the hardware from
enabling the gating schedule, the sja1105_tas_state_machine would
continuously detect and print that, spamming the kernel log, even if the
rules were subsequently deleted.

The rules themselves are _not_ active, because sja1105_init_scheduling
does enough of a job to not install the gating schedule in the static
config. But the virtual link rules themselves are still present.

So call the functions that remove the tc-gate configuration from
priv->tas_data.gating_cfg, so that tas_data->enabled can be set to
false, and sja1105_tas_state_machine will stop from being scheduled.

Fixes: 834f8933d5dd ("net: dsa: sja1105: implement tc-gate using time-triggered virtual links")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/sja1105/sja1105_vl.c