iio: light: opt3001: fix mutex unlock race
authorDavid Frey <dpfrey@gmail.com>
Thu, 19 Sep 2019 22:54:18 +0000 (15:54 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 9 Oct 2019 18:11:29 +0000 (19:11 +0100)
commit82f3015635249a8c8c45bac303fd84905066f04f
tree733c6c6bb18d153052a1be15dbc801e74c65271c
parentc62dd44901cfff12acc5792bf3d2dec20bcaf392
iio: light: opt3001: fix mutex unlock race

When an end-of-conversion interrupt is received after performing a
single-shot reading of the light sensor, the driver was waking up the
result ready queue before checking opt->ok_to_ignore_lock to determine
if it should unlock the mutex. The problem occurred in the case where
the other thread woke up and changed the value of opt->ok_to_ignore_lock
to false prior to the interrupt thread performing its read of the
variable. In this case, the mutex would be unlocked twice.

Signed-off-by: David Frey <dpfrey@gmail.com>
Reviewed-by: Andreas Dannenberg <dannenberg@ti.com>
Fixes: 94a9b7b1809f ("iio: light: add support for TI's opt3001 light sensor")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/opt3001.c