vrf: Fix use after free and double free in vrf_finish_output
authorDavid Ahern <dsahern@gmail.com>
Thu, 29 Mar 2018 19:49:52 +0000 (12:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Mar 2018 18:20:23 +0000 (14:20 -0400)
commit82dd0d2a9a76fc8fa2b18d80b987d455728bf83a
tree7f3f8308095869a157d285eb2bd95b9f2f894c3e
parent5807b22c9164a21cd1077a9bc587f0bba361f72d
vrf: Fix use after free and double free in vrf_finish_output

Miguel reported an skb use after free / double free in vrf_finish_output
when neigh_output returns an error. The vrf driver should return after
the call to neigh_output as it takes over the skb on error path as well.

Patch is a simplified version of Miguel's patch which was written for 4.9,
and updated to top of tree.

Fixes: 8f58336d3f78a ("net: Add ethernet header for pass through VRF device")
Signed-off-by: Miguel Fadon Perlines <mfadon@teldat.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vrf.c