mac80211: Fix misplaced return in AES-GMAC key setup
authorJouni Malinen <jouni@qca.qualcomm.com>
Mon, 23 Mar 2015 13:41:15 +0000 (15:41 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 30 Mar 2015 08:38:07 +0000 (10:38 +0200)
commit82ca6ef686f0fcefe2c1ad4ab74d5caf41be03a9
treef7cc1b260e63480f112995be1cac149ba868dec0
parent6bab2e19c5ffd1f21b28c2cabb3801a37b77ae69
mac80211: Fix misplaced return in AES-GMAC key setup

Commit 8ade538bf39b ("mac80111: Add BIP-GMAC-128 and BIP-GMAC-256
ciphers") had the success return in incorrect place before the
crypto_aead_setauthsize() call which practically ended up skipping that
call unconditionally.

The missing call did not actually change any functionality since
GMAC_MIC_LEN (16) is identical to the maxauthsize in gcm(aes) and as
such, the default value used for the authsize parameter.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/aes_gmac.c