webrtc, rtmp2: Fix parsing of userinfo in URI strings
authorNirbheek Chauhan <nirbheek@centricular.com>
Fri, 31 Jul 2020 20:42:21 +0000 (02:12 +0530)
committerNirbheek Chauhan <nirbheek@centricular.com>
Mon, 3 Aug 2020 18:12:50 +0000 (18:12 +0000)
commit827afa206d8c9675f2a7af402396552c2ed1df09
tree2dde087116c742fdf925ee6c13ab2d524666d55a
parent962ebebe066169592837af1227234e23191f286b
webrtc, rtmp2: Fix parsing of userinfo in URI strings

While parsing the string, `gst_uri_from_string()` also unescapes the
userinfo. This is bad if your username contains a `:` character, since
we will then split the userinfo at the wrong location when parsing it.

To fix this, we can use the new `gst_uri_from_string_escaped()` API
that was added in
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/583

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/831

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1481>
ext/webrtc/gstwebrtcice.c
gst/rtmp2/gstrtmp2locationhandler.c