media: davinci/vpbe: array underflow in vpbe_enum_outputs()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Apr 2019 09:46:27 +0000 (05:46 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:47 +0000 (14:50 +0100)
commit8276749b388f5f989676a0d316325db5ccf4292b
tree179f1590a56f929ba58c3a97e0d487e3f49318a7
parentc45bf72af1f5aede265f0a99c394e34ea4b1b3b1
media: davinci/vpbe: array underflow in vpbe_enum_outputs()

[ Upstream commit b72845ee5577b227131b1fef23f9d9a296621d7b ]

In vpbe_enum_outputs() we check if (temp_index >= cfg->num_outputs) but
the problem is that "temp_index" can be negative.  This patch changes
the types to unsigned to address this array underflow bug.

Fixes: 66715cdc3224 ("[media] davinci vpbe: VPBE display driver")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/davinci/vpbe.c
include/media/davinci/vpbe.h