[clang-tidy] Remove OptionError
authorNathan James <n.james93@hotmail.co.uk>
Mon, 1 Mar 2021 17:55:16 +0000 (17:55 +0000)
committerNathan James <n.james93@hotmail.co.uk>
Mon, 1 Mar 2021 17:55:17 +0000 (17:55 +0000)
commit82289aa6c88ad9840369db294cc66ed829e8c435
tree11d6738cf16f55604ee9aebc64a059dfe1a90220
parente745f7c563734bcc958d528714493ee79581d23a
[clang-tidy] Remove OptionError

The interface served a purpose, but since the ability to emit diagnostics when parsing configuration was added, its become mostly redundant. Emitting the diagnostic and removing the boilerplate is much cleaner.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D97614
clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
clang-tools-extra/clang-tidy/ClangTidyCheck.h
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp