spi: spi-mtk-nor: fix op checks in supports_op
authorChuanhong Guo <gch981213@gmail.com>
Thu, 24 Sep 2020 15:27:30 +0000 (23:27 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 1 Oct 2020 22:24:27 +0000 (23:24 +0100)
commit81f13f2116cd93910d958c58052ef7dc22f1e577
tree4cc41c530f05591be9bb577923681b40a1591d6e
parentfd806575921ab78c8f0ee7f4dd3d4bb7c16206c8
spi: spi-mtk-nor: fix op checks in supports_op

commit a59b2c7c56bf7 ("spi: spi-mtk-nor: support standard spi properties")
tries to inverse the logic of supports_op when adding
spi_mem_default_supports_op check, but it didn't get it done properly.
There are two regressions introduced by this commit:
1. reading ops supported by program mode is rejected.
2. all ops with special controller routines are incorrectly further
   checked against program mode.

This commits inverses the logic back:
1. check spi_mem_default_supports_op and reject unsupported ops first.
2. return true for ops with special controller routines.
3. check the left ops against controller program mode.

Fixes: a59b2c7c56bf7 ("spi: spi-mtk-nor: support standard spi properties")
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
Link: https://lore.kernel.org/r/20200924152730.733243-4-gch981213@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mtk-nor.c