wifi: ath12k: avoid deadlock by change ieee80211_queue_work for regd_update_work
authorWen Gong <quic_wgong@quicinc.com>
Tue, 18 Jul 2023 02:47:24 +0000 (22:47 -0400)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 3 Aug 2023 09:19:44 +0000 (12:19 +0300)
commit8198950ccb7d311f8b4389441d8dcb597f926340
treec421323a66966082f6a3b1197b06c53826bc17b6
parent9632ea57be659887ab0d28a2a1d7b901dfddd263
wifi: ath12k: avoid deadlock by change ieee80211_queue_work for regd_update_work

Deadlock is easily happened while shutdown wlan interface such as run
"ifconfig wlan0 down".

The reason is because when ar->regd_update_work is ran, it will
call wiphy_lock(ar->hw->wiphy) in function ath12k_regd_update() which
is running in workqueue of ieee80211_local queued by ieee80211_queue_work().
Another thread from "ifconfig wlan0 down" will also accuqire the lock
by wiphy_lock(sdata->local->hw.wiphy) in function ieee80211_stop(), and
then it call ieee80211_stop_device() to flush_workqueue(local->workqueue),
this will wait the workqueue of ieee80211_local finished. Then deadlock
will happen easily if the two thread run meanwhile.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4

Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230718024724.29120-1-quic_wgong@quicinc.com
drivers/net/wireless/ath/ath12k/wmi.c