spi: imx: Fix failure path leak on GPIO request error correctly
authorTrent Piepho <tpiepho@impinj.com>
Mon, 6 Nov 2017 18:38:23 +0000 (10:38 -0800)
committerMark Brown <broonie@kernel.org>
Tue, 7 Nov 2017 10:20:19 +0000 (11:20 +0100)
commit8197f489f4c4398391746a377c10501076b05168
treeb764cb0ab9ee903139777e7500b36de8f440a607
parent974488e4ce1ed0b39f2c711c13f523c5912128a1
spi: imx: Fix failure path leak on GPIO request error correctly

In commit 974488e4ce1e ("spi: imx: Fix failure path leak on GPIO request
error"), spi_bitbang_start() was moved later in the probe sequence.  But
this doesn't work, as spi_bitbang_start() has to be called before
requesting GPIOs because the GPIO data in the spi master is populated when
the master is registed, and that doesn't happen until spi_bitbang_start()
is called.  The default only works if one uses one CS.

So add a failure path call to spi_bitbang_stop() to fix the leak.

CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <kernel@pengutronix.de>
CC: Fabio Estevam <fabio.estevam@nxp.com>
CC: Mark Brown <broonie@kernel.org>
CC: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c