wifi: ath12k: mhi: fix potential memory leak in ath12k_mhi_register()
authorMa Ke <make_ruc2021@163.com>
Sat, 30 Sep 2023 04:54:47 +0000 (07:54 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:19:38 +0000 (17:19 +0000)
commit8175a9f662f7a2742a2c37735e76a39c036df00b
treeecabf84620364c1a40ad5274ded8a0c949b140dd
parent87324a50b4e833289bbe22339eccbc42e4d0578a
wifi: ath12k: mhi: fix potential memory leak in ath12k_mhi_register()

[ Upstream commit 47c27aa7ded4b8ead19b3487cc42a6185b762903 ]

mhi_alloc_controller() allocates a memory space for mhi_ctrl. When some
errors occur, mhi_ctrl should be freed by mhi_free_controller() and set
ab_pci->mhi_ctrl = NULL.

We can fix it by calling mhi_free_controller() when the failure happens
and set ab_pci->mhi_ctrl = NULL in all of the places where we call
mhi_free_controller().

Signed-off-by: Ma Ke <make_ruc2021@163.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230922021036.3604157-1-make_ruc2021@163.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/ath/ath12k/mhi.c