review.tizen.org Git - kernel/kernel-generic.git/commit

author	Emmanuel Grumbach <emmanuel.grumbach@intel.com>
	Tue, 5 Feb 2013 08:08:35 +0000 (10:08 +0200)
committer	Johannes Berg <johannes.berg@intel.com>
	Mon, 11 Feb 2013 10:54:27 +0000 (11:54 +0100)
commit	8115efbdc82acc935b54f0a849eb834129ea1fd0
tree	e1f125c030647f0c9ea2f63d0a7c6d0a12a64229	tree \| snapshot
parent	456f6ddf9cfd876a60df259dbe4f3cb943e773b4	commit \| diff

iwlwifi: mvm: fix the keyidx assignment

Fixes an issue that smatch pointed out:

  1118
  1119          key_flags = cpu_to_le16(keyconf->keyidx &  STA_KEY_FLG_KEYID_MSK);
                                        ^^^^^^^^^^^^^^^
This is s8.
                                                          ^^^^^^^^^^^^^^^^^^^^^
STA_KEY_FLG_KEYID_MSK is 0x300.

The result after the bitwise AND is always zero because 0xff & 0x300.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>