kprobes/x86: Just return error for sanity check failure instead of using BUG_ON
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thu, 4 Apr 2013 10:42:30 +0000 (19:42 +0900)
committerIngo Molnar <mingo@kernel.org>
Mon, 8 Apr 2013 15:28:34 +0000 (17:28 +0200)
commit8101376dc5f42bd93b36d4ab210b44503d0ec11f
tree7adb1e6a9ab280da5ce3e4fdc4f1e6fc42a2b4db
parent324670b620ab1ed00ba160e435686bd2ae4a59ce
kprobes/x86: Just return error for sanity check failure instead of using BUG_ON

Return an error from __copy_instruction() and use printk() to
give us a more productive message, since this is just an error
case which we can handle and also the BUG_ON() never tells us
why and what happened.

This is related to the following bug-report:

   https://bugzilla.redhat.com/show_bug.cgi?id=910649

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Frank Ch. Eigler <fche@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: yrl.pp-manager.tt@hitachi.com
Link: http://lkml.kernel.org/r/20130404104230.22862.85242.stgit@mhiramat-M0-7522
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/kprobes/core.c