tests/cris: Fix some errors and potential crashes
authorStefan Weil <weil@mail.berlios.de>
Sun, 3 Apr 2011 19:36:36 +0000 (21:36 +0200)
committerEdgar E. Iglesias <edgar.iglesias@gmail.com>
Sun, 3 Apr 2011 19:58:38 +0000 (21:58 +0200)
commit80fac245aea2dfbbb9b6814e863a531dc07ab5a5
treee37790dd76f7d53761522dea178296251db90501
parent3216e03ced9dd656d6bc8353ced49571c1b6a4e7
tests/cris: Fix some errors and potential crashes

These errors were reported by cppcheck:

tests/cris/check_openpf1.c:30: error:
Mismatching allocation and deallocation: f

tests/cris/check_openpf2.c:13: error:
Mismatching allocation and deallocation: f

tests/cris/check_stat3.c:16: error:
Buffer overrun possible for long cmd-line args

tests/cris/check_stat4.c:18: error:
Buffer overrun possible for long cmd-line args

The first two are obvious coding errors (fopen needs fclose, not close).

The last two may seem less important (nobody will start test code
with an argument of more than 1022 characters which raises a buffer
overrun). Fixing them nevertheless helps with static code checks
like those done by cppcheck.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
tests/cris/check_openpf1.c
tests/cris/check_openpf2.c
tests/cris/check_stat3.c
tests/cris/check_stat4.c