radeonsi: fix refcnt imbalance related to util_blitter_save_fragment_constant_buffer_...
authorPatrick Lerda <patrick9876@free.fr>
Thu, 22 Jun 2023 11:11:07 +0000 (13:11 +0200)
committerMarge Bot <emma+marge@anholt.net>
Wed, 5 Jul 2023 20:01:09 +0000 (20:01 +0000)
commit80ccc3f822d32f014ccb7ab7283a1a80e6f7d9ca
tree3148d477c76784a82b2b85e821daea7e2b5645ca
parentfb5ecbb4fe9d9f58afee341116def699f3bb8341
radeonsi: fix refcnt imbalance related to util_blitter_save_fragment_constant_buffer_slot()

Indeed, util_blitter_clear() requires a call to
util_blitter_save_fragment_constant_buffer_slot(),
but most other blitter functions do not.

For instance, this issue is triggered with:
"piglit/bin/object-namespace-pollution glDrawPixels buffer -auto -fbo"
while setting GALLIUM_REFCNT_LOG=refcnt.log.

Fixes: 03bc7503d471 ("radeonsi: save the fs constant buffer to the util blitter context")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23856>
src/gallium/drivers/radeonsi/si_blit.c
src/gallium/drivers/radeonsi/si_clear.c
src/gallium/drivers/radeonsi/si_pipe.h