mmc: renesas_sdhi: Convert to platform remove callback returning void
authorYangtao Li <frank.li@vivo.com>
Thu, 27 Jul 2023 07:00:45 +0000 (15:00 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 15 Aug 2023 10:48:20 +0000 (12:48 +0200)
commit80c602b1144f926839d5a74e16fc0fb3c1284649
tree3520327cb1a7a5f257c70557af09aa737378637f
parent5c57f6c47da2f228854cd9547f005efad8a0e07b
mmc: renesas_sdhi: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230727070051.17778-56-frank.li@vivo.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/renesas_sdhi.h
drivers/mmc/host/renesas_sdhi_core.c
drivers/mmc/host/renesas_sdhi_internal_dmac.c
drivers/mmc/host/renesas_sdhi_sys_dmac.c