scsi: sg: Fix checking return value of blk_get_queue()
authorYu Kuai <yukuai3@huawei.com>
Wed, 5 Jul 2023 02:40:01 +0000 (10:40 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 20 Jul 2023 03:12:13 +0000 (23:12 -0400)
commit80b6051085c5fedcb1dfd7b2562a63a83655c4d8
treedb735bdc058d9c0148667b134d31371f3396c1a2
parentf4d1a8e011909fee24643f84bd1196e1366c26f2
scsi: sg: Fix checking return value of blk_get_queue()

Commit fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference") make
a mess how blk_get_queue() is called, blk_get_queue() returns true on
success while the caller expects it returns 0 on success.

Fix this problem and also add a corresponding error message on failure.

Fixes: fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Closes: https://lore.kernel.org/all/87lefv622n.fsf@linux.ibm.com/
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20230705024001.177585-1-yukuai1@huaweicloud.com
Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sg.c