bpf: fix direct packet write into pop/peek helpers
authorDaniel Borkmann <daniel@iogearbox.net>
Wed, 24 Oct 2018 20:05:47 +0000 (22:05 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 26 Oct 2018 00:02:06 +0000 (17:02 -0700)
commit80b0d86a176cab6201719b8dfd806902b0c6e046
tree83740a6f5a2d27764c8cd5833546cd3e9cdaf8c8
parentd5563d367c2ce48ea3d675c77f7109f37311943d
bpf: fix direct packet write into pop/peek helpers

Commit f1a2e44a3aec ("bpf: add queue and stack maps") probably just
copy-pasted .pkt_access for bpf_map_{pop,peek}_elem() helpers, but
this is buggy in this context since it would allow writes into cloned
skbs which is invalid. Therefore, disable .pkt_access for the two.

Fixes: f1a2e44a3aec ("bpf: add queue and stack maps")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Cc: Mauricio Vasquez B <mauricio.vasquez@polito.it>
Acked-by: Mauricio Vasquez B<mauricio.vasquez@polito.it>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/helpers.c