drm/edid/firmware: stop using a throwaway platform device
authorJani Nikula <jani.nikula@intel.com>
Mon, 14 Nov 2022 11:17:09 +0000 (13:17 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 16 Nov 2022 12:54:44 +0000 (14:54 +0200)
commit80afdfa66ca9df85c483a9e89fe6cb8483cd6381
tree6cdadd0671faea3519e0f3b7e1f343c5ec57a573
parent0ba2fa8cbd29278a180ac90bd66b2c0bbdeacc89
drm/edid/firmware: stop using a throwaway platform device

We've used a temporary platform device for firmware EDID loading since
it was introduced in commit da0df92b5731 ("drm: allow loading an EDID as
firmware to override broken monitor"), but there's no explanation why.

Using a temporary device does not play well with CONFIG_FW_CACHE=y,
which caches firmware images (e.g. on suspend) so that drivers can
request firmware when the system is not ready for it, and return the
images from the cache (e.g. during resume). This works automatically for
regular devices, but obviously not for a temporarily created device.

Stop using the throwaway platform device, and use the drm device
instead.

Note that this may still be problematic for cases where the display was
plugged in during suspend, and the firmware wasn't loaded and therefore
not cached before suspend.

References: https://lore.kernel.org/r/20220727074152.43059-1-matthieu.charette@gmail.com
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2061
Reported-by: Matthieu CHARETTE <matthieu.charette@gmail.com>
Tested-by: Matthieu CHARETTE <matthieu.charette@gmail.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20221114111709.434979-1-jani.nikula@intel.com
drivers/gpu/drm/drm_edid_load.c