c++: Redundant -Wdeprecated-declarations warning in build_over_call [PR67960]
authorPatrick Palka <ppalka@redhat.com>
Thu, 12 Mar 2020 18:38:42 +0000 (14:38 -0400)
committerPatrick Palka <ppalka@redhat.com>
Fri, 13 Mar 2020 14:30:36 +0000 (10:30 -0400)
commit80a13af724aedfb360893dcc16aa7cc12ca49799
treebc95d793f4402174bed2e31fca4c5299ffcb470a
parent3604480a6fe493c51d6ebd53d9b1abeebbbb828f
c++: Redundant -Wdeprecated-declarations warning in build_over_call [PR67960]

In build_over_call, we are emitting a redundant -Wdeprecated-declarations
warning about the deprecated callee function, first from mark_used and again
from build_addr_func <- decay_conversion <- cp_build_addr_expr <- mark_used.

It seems this second deprecation warning coming from build_addr_func will always
be redundant, so we can safely use a warning_sentinel to disable it before
calling build_addr_func.  (And any deprecation warning that could come from
build_addr_func would be for FN, so we wouldn't be suppressing too much.)

gcc/cp/ChangeLog:

PR c++/67960
* call.c (build_over_call): Use a warning_sentinel to disable
warn_deprecated_decl before calling build_addr_func.

gcc/testsuite/ChangeLog:

PR c++/67960
* g++.dg/diagnostic/pr67960.C: New test.
* g++.dg/diagnostic/pr67960-2.C: New test.
gcc/cp/ChangeLog
gcc/cp/call.c
gcc/testsuite/ChangeLog
gcc/testsuite/g++.dg/diagnostic/pr67960-2.C [new file with mode: 0644]
gcc/testsuite/g++.dg/diagnostic/pr67960.C [new file with mode: 0644]