libbpf: Fix compatibility problem in xsk_socket__create
authorMagnus Karlsson <magnus.karlsson@intel.com>
Wed, 7 Oct 2020 11:42:26 +0000 (13:42 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 7 Oct 2020 20:28:43 +0000 (22:28 +0200)
commit80348d8867c65e2c64ca78d82326e889550a24b6
tree86512b4e9c2b3eccc0c170d3e6a7512f2d37bb22
parent49f3d12b0f70ea867b891ad2a97f6e51bb564e18
libbpf: Fix compatibility problem in xsk_socket__create

Fix a compatibility problem when the old XDP_SHARED_UMEM mode is used
together with the xsk_socket__create() call. In the old XDP_SHARED_UMEM
mode, only sharing of the same device and queue id was allowed, and
in this mode, the fill ring and completion ring were shared between
the AF_XDP sockets.

Therefore, it was perfectly fine to call the xsk_socket__create() API
for each socket and not use the new xsk_socket__create_shared() API.
This behavior was ruined by the commit introducing XDP_SHARED_UMEM
support between different devices and/or queue ids. This patch restores
the ability to use xsk_socket__create in these circumstances so that
backward compatibility is not broken.

Fixes: 2f6324a3937f ("libbpf: Support shared umems between queues and devices")
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/1602070946-11154-1-git-send-email-magnus.karlsson@gmail.com
tools/lib/bpf/xsk.c