media: em28xx: calculate left volume level correctly
authorColin Ian King <colin.king@canonical.com>
Tue, 22 Aug 2017 14:21:20 +0000 (10:21 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 26 Aug 2017 18:31:49 +0000 (14:31 -0400)
commit801e3659bf2c87c31b7024087d61e89e172b5651
treeacb1a75ea438bc18f8bc924798b9722c1e1333ca
parentbd9f8f750e238f8a6160fb053ae97016f6da1098
media: em28xx: calculate left volume level correctly

The calculation of the left volume looks suspect, the value of
0x1f - ((val << 8) & 0x1f) is always 0x1f. The debug prior to the
assignment of value[1] prints the left volume setting using the
calculation 0x1f - (val >> 8) & 0x1f which looks correct to me.
Fix the left volume by using the correct expression as used in
the debug.

Detected by CoverityScan, CID#146140 ("Wrong operator used")

Fixes: 850d24a5a861 ("[media] em28xx-alsa: add mixer support for AC97 volume controls")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/em28xx/em28xx-audio.c