can: c_can: precedence error in c_can_chip_config()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 15 Jun 2012 00:20:44 +0000 (00:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Jul 2012 16:04:20 +0000 (09:04 -0700)
commit8010204c43b1b1543b35972060a0dcaea2cce6fe
tree0b115279dd19e9b7e18bf926ba90882ba885c5a7
parent7cc0ab128f8866767113eece040dc838175901b2
can: c_can: precedence error in c_can_chip_config()

commit d9cb9bd63eb27ac19f26a8547128c053f43a5da8 upstream.

(CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
is zero so the condition is never true.  The intent here was to test
that both flags were set.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/c_can/c_can.c