firmware: arm_scmi: Fix list protocols enumeration in the base protocol
authorCristian Marussi <cristian.marussi@arm.com>
Wed, 30 Mar 2022 15:05:32 +0000 (16:05 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Thu, 28 Apr 2022 09:48:21 +0000 (10:48 +0100)
commit8009120e0354a67068e920eb10dce532391361d0
tree2abe3c2b4dd2d572cade2ec09055500101275a31
parent4de1b36fae866c02f264f6bcda7a9a9e00ec5306
firmware: arm_scmi: Fix list protocols enumeration in the base protocol

While enumerating protocols implemented by the SCMI platform using
BASE_DISCOVER_LIST_PROTOCOLS, the number of returned protocols is
currently validated in an improper way since the check employs a sum
between unsigned integers that could overflow and cause the check itself
to be silently bypassed if the returned value 'loop_num_ret' is big
enough.

Fix the validation avoiding the addition.

Link: https://lore.kernel.org/r/20220330150551.2573938-4-cristian.marussi@arm.com
Fixes: b6f20ff8bd94 ("firmware: arm_scmi: add common infrastructure and support for base protocol")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/base.c