gpio: sysfs: change 'value' attribute to prealloc
authorChristophe Leroy <christophe.leroy@c-s.fr>
Mon, 18 Dec 2017 10:08:29 +0000 (11:08 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 20 Dec 2017 09:28:05 +0000 (10:28 +0100)
commit7fda9100bb8258bbdff90f3db5079d28eb9b0013
treef6927adaf0e19517d09d0dda7b12558dfdbe7b1e
parentfcf273e5807976009dbb5ffb00bd5b9091843fe6
gpio: sysfs: change 'value' attribute to prealloc

The GPIO 'value' attribute is time critical. A small bench with
'perf record' on the app below shows that 80% of the time spent in
sysfs_kf_seq_show() is spent in memset() for zeroising the buffer.

|--67.48%--sysfs_kf_seq_show
|          |
|          |--54.40%--memset
|          |
|          |--11.49%--dev_attr_show
|          |          |
|          |          |--10.06%--value_show
|          |          |          |
|          |          |          |--4.75%--sprintf
|          |          |          |          |

This patch changes the attribute type to prealloc, eliminating the
need to zeroise the buffer at each read. 'perf record' gives the
following result.

|--42.41%--sysfs_kf_read
|          |
|          |--39.73%--dev_attr_show
|          |          |
|          |          |--38.23%--value_show
|          |          |          |
|          |          |          |--29.22%--sprintf
|          |          |          |          |

Test done with the following small app:

int main(int argc, char **argv)
{
int fd = open(argv[1], O_RDONLY);

for (;;) {
int buf[512];

read(fd, buf, 512);
lseek(fd, 0, SEEK_SET);
}
exit(0);
}

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib-sysfs.c
include/linux/device.h